[JENKINS-72803]: Disable agent name "(built-in)" #9128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-72803.
This issue aims to resolve [JENKINS-72803].
Since "(built-in)" is a default agent name in Jenkins, if user creates another agent with this name, Jenkins will recognize them as the same one and user cannot operate the created one.
After investigating this issue, it is more feasible and efficient for us to ban "(built-in)" to be used as an agent name. Enforcing the system to distinguish the original built-in agent and the user-created agent can be problematic with low ROI.
Since "%" is already banned, so we don't need to worry about URL encoding bypass.
Screenshot (After):
When user wants to create a new agent with name "(built-in)":
Testing done
a. If I create an agent with name "(built-in)", system will reject due to invalid name.
b. variations such as "(Built-in)", "(bUILT-in)", "XXX (built-in)" are tested and did not produce problems.
Proposed changelog entries
Remove JENKINS-72803 if there is no issue for the pull request.
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
Before the changes are marked as
ready-for-merge:Maintainer checklist